Skip to content

Add missing request type for mock GitHub API#1633

Merged
koesie10 merged 1 commit intomainfrom
koesie10/add-missing-mock-type
Oct 19, 2022
Merged

Add missing request type for mock GitHub API#1633
koesie10 merged 1 commit intomainfrom
koesie10/add-missing-mock-type

Conversation

@koesie10
Copy link
Copy Markdown
Member

We were still missing the SubmitVariantAnalysisRequest type and a type to represent the union of all request types. This adds both of them.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

We were still missing the `SubmitVariantAnalysisRequest` type and a type
to represent the union of all request types. This adds both of them.
@koesie10 koesie10 requested review from a team and charisk October 19, 2022 14:27
@koesie10 koesie10 requested a review from a team as a code owner October 19, 2022 14:27
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@koesie10 koesie10 merged commit fe31730 into main Oct 19, 2022
@koesie10 koesie10 deleted the koesie10/add-missing-mock-type branch October 19, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants